Update github workflow for GPU Tests #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praateek Mahajan <[email protected]>
VibhuJawa
reviewed
Sep 23, 2024
|
|
||
| python-gpu-tests: | ||
| secrets: inherit | ||
| uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-24.06 | ||
| uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-24.08 |
There was a problem hiding this comment.
Agreed, lets also change the base image to rapidsai/base:24.08-cuda12.2-py3.11
Signed-off-by: Praateek Mahajan <[email protected]>
Signed-off-by: Praateek Mahajan <[email protected]>
VibhuJawa
approved these changes
Sep 24, 2024
praateekmahajan
added a commit
to praateekmahajan/crossfit
that referenced
this pull request
Sep 24, 2024
* refer to 24.08 gh workflows Signed-off-by: Praateek Mahajan <[email protected]> * update docker img Signed-off-by: Praateek Mahajan <[email protected]> * skip pytest Signed-off-by: Praateek Mahajan <[email protected]> --------- Signed-off-by: Praateek Mahajan <[email protected]>
VibhuJawa
pushed a commit
that referenced
this pull request
Sep 24, 2024
* first commit Signed-off-by: Praateek Mahajan <[email protected]> * remove dead import Signed-off-by: Praateek Mahajan <[email protected]> * add return type hint Signed-off-by: Praateek Mahajan <[email protected]> * fixes Signed-off-by: Praateek Mahajan <[email protected]> * pre-commit Signed-off-by: Praateek Mahajan <[email protected]> * np.NaN -> np.nan Signed-off-by: Praateek Mahajan <[email protected]> * fix version checking Signed-off-by: Praateek Mahajan <[email protected]> * Update github workflow for GPU Tests (#87) * refer to 24.08 gh workflows Signed-off-by: Praateek Mahajan <[email protected]> * update docker img Signed-off-by: Praateek Mahajan <[email protected]> * skip pytest Signed-off-by: Praateek Mahajan <[email protected]> --------- Signed-off-by: Praateek Mahajan <[email protected]> * pre-commit Signed-off-by: Praateek Mahajan <[email protected]> * change how version is understood for cudf Signed-off-by: Praateek Mahajan <[email protected]> * move import out Signed-off-by: Praateek Mahajan <[email protected]> --------- Signed-off-by: Praateek Mahajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapidsai/shared-workflows changed how it gets pr info between 24.06 and 24.08
https://github.com/rapidsai/shared-workflows/blob/6a9688257b61f25dc7b772acbb38df09585f33cb/.github/workflows/custom-job.yaml#L75-L76
https://github.com/rapidsai/shared-workflows/blob/b7f6ccf8448dd5a2e6af883fe3f865808256d9f6/.github/workflows/custom-job.yaml#L70-L71
We also updated the docker container to use
24.08