Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CCCL 2.3.0. #14704

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conda/recipes/libcudf/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ requirements:
- ninja
- sysroot_{{ target_platform }} {{ sysroot_version }}
host:
- librmm ={{ minor_version }}
# Force librmm to be fetched by CPM
#- librmm ={{ minor_version }}
- libkvikio ={{ minor_version }}
{% if cuda_major == "11" %}
- cudatoolkit
Expand Down
8 changes: 4 additions & 4 deletions cpp/src/groupby/sort/group_rank_scan.cu
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021-2023, NVIDIA CORPORATION.
* Copyright (c) 2021-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -133,10 +133,10 @@ std::unique_ptr<column> rank_generator(column_view const& grouped_values,

auto [group_labels_begin, mutable_rank_begin] = [&]() {
if constexpr (forward) {
return thrust::pair{group_labels.begin(), mutable_ranks.begin<size_type>()};
return thrust::make_pair(group_labels.begin(), mutable_ranks.begin<size_type>());
} else {
return thrust::pair{thrust::reverse_iterator(group_labels.end()),
thrust::reverse_iterator(mutable_ranks.end<size_type>())};
return thrust::make_pair(thrust::reverse_iterator(group_labels.end()),
thrust::reverse_iterator(mutable_ranks.end<size_type>()));
}
}();
thrust::inclusive_scan_by_key(rmm::exec_policy(stream),
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/io/comp/nvcomp_adapter.cu
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022-2023, NVIDIA CORPORATION.
* Copyright (c) 2022-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -108,7 +108,7 @@ void skip_unsupported_inputs(device_span<size_t> input_sizes,
input_sizes.begin(),
status_size_it,
[] __device__(auto const& status) {
return thrust::pair{0, compression_result{0, compression_status::SKIPPED}};
return thrust::make_pair(0, compression_result{0, compression_status::SKIPPED});
},
[max_size = max_valid_input_size.value()] __device__(size_t input_size) {
return input_size > max_size;
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/io/orc/writer_impl.cu
Original file line number Diff line number Diff line change
Expand Up @@ -1833,7 +1833,7 @@ orc_table_view make_orc_table_view(table_view const& table,
thrust::make_reverse_iterator(d_table.end()),
thrust::make_reverse_iterator(d_table.begin()),
[&stack](column_device_view const& c) {
stack.push({&c, thrust::nullopt});
stack.push({&c, thrust::optional<uint32_t>{}});
});

uint32_t idx = 0;
Expand Down
5 changes: 3 additions & 2 deletions cpp/src/lists/contains.cu
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,10 @@ __device__ auto element_index_pair_iter(size_type const size)
auto const end = thrust::make_counting_iterator(size);

if constexpr (forward) {
return thrust::pair{begin, end};
return thrust::make_pair(begin, end);
} else {
return thrust::pair{thrust::make_reverse_iterator(end), thrust::make_reverse_iterator(begin)};
return thrust::make_pair(thrust::make_reverse_iterator(end),
thrust::make_reverse_iterator(begin));
}
}

Expand Down
2 changes: 2 additions & 0 deletions rapids_config.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ else()
)
endif()

set(rapids-cmake-repo bdice/rapids-cmake)
set(rapids-cmake-branch cccl-2.3.0)
if(NOT EXISTS "${CMAKE_CURRENT_BINARY_DIR}/CUDF_RAPIDS-${RAPIDS_VERSION_MAJOR_MINOR}.cmake")
file(
DOWNLOAD
Expand Down
Loading