Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-tidy to CI #16958

Merged
merged 38 commits into from
Oct 14, 2024
Merged

Add clang-tidy to CI #16958

merged 38 commits into from
Oct 14, 2024

Commits on Oct 9, 2024

  1. clang-tidy

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    69b8c9b View commit details
    Browse the repository at this point in the history

  2. Set up pre-commit

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c985bca View commit details
    Browse the repository at this point in the history

  3. Update CI

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    01da077 View commit details
    Browse the repository at this point in the history

  4. Make hook suitable for testing

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2b846c7 View commit details
    Browse the repository at this point in the history

  5. Fix permissions

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    034fcc2 View commit details
    Browse the repository at this point in the history

  6. Allow unbound variables

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    64f0ae4 View commit details
    Browse the repository at this point in the history

  7. Configure with ninja

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e17c70b View commit details
    Browse the repository at this point in the history

  8. Only run clang-tidy

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    44ef5ac View commit details
    Browse the repository at this point in the history

  9. Up the parallelism

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a6008a6 View commit details
    Browse the repository at this point in the history

  10. Update for CI failure

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    64046a3 View commit details
    Browse the repository at this point in the history

  11. Up the parallelism again to see

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e70a752 View commit details
    Browse the repository at this point in the history

  12. Make sure nvrtc is installed

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    87547f0 View commit details
    Browse the repository at this point in the history

  13. Reduce parallelism

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5561faf View commit details
    Browse the repository at this point in the history

  14. Generate headers from jitify so that they're available

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    26aa432 View commit details
    Browse the repository at this point in the history

  15. Enable clang-tidy checking via CMake

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    00dcbf0 View commit details
    Browse the repository at this point in the history

  16. Remove now obsolete script

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1b2debe View commit details
    Browse the repository at this point in the history

  17. Make clang-tidy available in the conda environment

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7f98c52 View commit details
    Browse the repository at this point in the history

  18. Remove the pre-commit hook

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    051ded8 View commit details
    Browse the repository at this point in the history

  19. Update the CI script

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    74ef32c View commit details
    Browse the repository at this point in the history

  20. Test commit introducing a clang-tidy error

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a8dbb83 View commit details
    Browse the repository at this point in the history

  21. Redefine variable

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    17f3ce9 View commit details
    Browse the repository at this point in the history

  22. Just inline it

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4b97bd1 View commit details
    Browse the repository at this point in the history

  23. Set up sccache to avoid recompilation

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c25da56 View commit details
    Browse the repository at this point in the history

  24. Revert "Test commit introducing a clang-tidy error" 

    This reverts commit e679f4b.
    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c95ce44 View commit details
    Browse the repository at this point in the history

  25. Add a version check to the CMake

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    443df30 View commit details
    Browse the repository at this point in the history

  26. Make sure to run in parallel, it's unclear if clang-tidy is serializing

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6bcacc6 View commit details
    Browse the repository at this point in the history

  27. Revert "Make sure to run in parallel, it's unclear if clang-tidy is s… 

    …erializing"

This reverts commit 6bcacc6.
    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    435d2b9 View commit details
    Browse the repository at this point in the history

  28. Add note about moving the check to nightly

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1c51256 View commit details
    Browse the repository at this point in the history

  29. Add some notes

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4a0c50b View commit details
    Browse the repository at this point in the history

  30. Apply suggestions from code review 

    Co-authored-by: Bradley Dice <[email protected]>
    @vyasr @bdice
    vyasr and bdice authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3ba5e83 View commit details
    Browse the repository at this point in the history

  31. Add clang back to develop environment

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    aa33ba0 View commit details
    Browse the repository at this point in the history

  32. Fix pr-builder

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a0f60e7 View commit details
    Browse the repository at this point in the history

  33. Fix dependency groups to avoid conflicts

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    25e1a95 View commit details
    Browse the repository at this point in the history

  34. typo

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7536de6 View commit details
    Browse the repository at this point in the history

  35. Apply suggestions from code review 

    Co-authored-by: Kyle Edwards <[email protected]>
    @vyasr @KyleFromNVIDIA
    vyasr and KyleFromNVIDIA authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    600b406 View commit details
    Browse the repository at this point in the history

  36. Fix style

    @vyasr
    vyasr committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c4691f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Move workflow to nightly and fix static configure parameters

    @vyasr
    vyasr committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8b7a356 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-24.12' into feat/clang_tidy_ci

    @vyasr
    vyasr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    432265d View commit details
    Browse the repository at this point in the history