Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary std::move's in pylibcudf #16983

Merged
merged 8 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/pylibcudf/pylibcudf/strings/convert/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@
set(cython_sources convert_durations.pyx convert_datetime.pyx)

set(linked_libraries cudf::cudf)

# Set the Cython flags to include annotation
set(CYTHON_FLAGS "--annotate")
Matt711 marked this conversation as resolved.
Show resolved Hide resolved

rapids_cython_create_modules(
CXX
SOURCE_FILES "${cython_sources}"
LINKED_LIBRARIES "${linked_libraries}" MODULE_PREFIX pylibcudf_strings_ ASSOCIATED_TARGETS cudf
CYTHON_FLAGS "${CYTHON_FLAGS}" # Pass the annotate flag to cython
)
4 changes: 4 additions & 0 deletions python/pylibcudf/pylibcudf/strings/split/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@

set(cython_sources partition.pyx split.pyx)

# Set the Cython flags to include annotation
set(CYTHON_FLAGS "--annotate")

set(linked_libraries cudf::cudf)
rapids_cython_create_modules(
CXX
SOURCE_FILES "${cython_sources}"
LINKED_LIBRARIES "${linked_libraries}" MODULE_PREFIX pylibcudf_strings_ ASSOCIATED_TARGETS cudf
CYTHON_FLAGS "${CYTHON_FLAGS}" # Pass the annotate flag to cython
)
16 changes: 6 additions & 10 deletions python/pylibcudf/pylibcudf/strings/split/partition.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,9 @@ cpdef Table partition(Column input, Scalar delimiter=None):
)

with nogil:
c_result = move(
cpp_partition.partition(
input.view(),
dereference(c_delimiter)
)
c_result = cpp_partition.partition(
input.view(),
dereference(c_delimiter)
)

return Table.from_libcudf(move(c_result))
Expand Down Expand Up @@ -85,11 +83,9 @@ cpdef Table rpartition(Column input, Scalar delimiter=None):
)

with nogil:
c_result = move(
cpp_partition.rpartition(
input.view(),
dereference(c_delimiter)
)
c_result = cpp_partition.rpartition(
input.view(),
dereference(c_delimiter)
)

return Table.from_libcudf(move(c_result))
Loading