-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests more deterministic #17008
Open
galipremsagar
wants to merge
30
commits into
rapidsai:branch-24.12
Choose a base branch
from
galipremsagar:numpy_random
base: branch-24.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,496
−5,288
Open
Changes from 18 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
8b462e8
use nep rule
galipremsagar 763ae35
update pre-commit config
galipremsagar 027e148
first pass
galipremsagar 828706e
Switch numpy random calls to latest API
galipremsagar 40ad066
Merge remote-tracking branch 'upstream/branch-24.12' into numpy_random
galipremsagar 858afbb
improve
galipremsagar 16e61b2
Merge branch 'branch-24.12' into numpy_random
galipremsagar 66edb86
Merge remote-tracking branch 'upstream/branch-24.12' into numpy_random
galipremsagar ebaa562
more fixes
galipremsagar e100e2d
fix issues
galipremsagar 33234fc
fix more failures
galipremsagar 5915e5b
update pre-commit
galipremsagar 7087da9
Merge remote-tracking branch 'upstream/branch-24.12' into numpy_random
galipremsagar 3d35be1
fix default seed
galipremsagar 8336a5f
style
galipremsagar cd7e198
update files
galipremsagar bc73f31
update
galipremsagar 4e81055
Merge remote-tracking branch 'upstream/branch-24.12' into numpy_random
galipremsagar 0939ba1
update
galipremsagar 8f4efb7
update
galipremsagar de0813c
update notebook
galipremsagar 3158d9c
Apply suggestions from code review
galipremsagar a02907b
address reviews
galipremsagar 56f8ee0
Merge branch 'numpy_random' of https://github.com/galipremsagar/cudf …
galipremsagar 4f3ca74
Merge remote-tracking branch 'upstream/branch-24.12' into numpy_random
galipremsagar 4a9e944
merge into one
galipremsagar b8f964b
address reviews
galipremsagar 5a7afc6
Merge remote-tracking branch 'upstream/branch-24.12' into numpy_random
galipremsagar 2350a46
fix struct data type corruption
galipremsagar ab1ddda
Merge branch 'branch-24.12' into numpy_random
galipremsagar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a preference to keep these checks separated? Seems like we could do something similar to the check that @mroeschke linked in consolidating all of these entries into a single check that runs against all Python files at once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I quite like the separate entries, since the name of the entry gives some information as to what went wrong. If the regex gets complicated, I find it hard to see what's going on. But I don't have strong feelings here.