Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: use self.ck_consumer in poll method of kafka.py to align with __init__ #17044

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

a-hirota
Copy link
Contributor

Description

Updated the poll method in kafka.py to use self.ck_consumer.poll(timeout) instead of self.ck.poll(timeout). This change ensures consistency with the __init__ method where self.ck_consumer is initialized.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Oct 10, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Oct 10, 2024
@wence-
Copy link
Contributor

wence- commented Oct 11, 2024

Thanks for this contribution. Unfortunately, something seems to have gone wrong with the merges in your branch. I think it's only a one-line change? Perhaps you can cherry pick it onto the tip of branch-24.12 and then force push

@github-actions github-actions bot removed Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Oct 14, 2024
@a-hirota a-hirota changed the title fix: use self.ck_consumer in poll method of kafka.py to align with __init__ bug fix: use self.ck_consumer in poll method of kafka.py to align with __init__ Oct 14, 2024
@a-hirota
Copy link
Contributor Author

I apologize for cluttering the pull request.
The only file and change I intended to update is one line in kafka.py.

@wence-
Copy link
Contributor

wence- commented Oct 14, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Oct 14, 2024

@a-hirota please install pre-commit and run pre-commit run --all-files on your machine. That should fix the copyright issue that is blocking CI here.

@ttnghia ttnghia removed the request for review from a team October 15, 2024 03:04
@a-hirota
Copy link
Contributor Author

I have executed the instructed script, and the copyright has been updated as follows. Does this look good now?

-# Copyright (c) 2020-2023, NVIDIA CORPORATION.
+# Copyright (c) 2020-2024, NVIDIA CORPORATION.

@wence-
Copy link
Contributor

wence- commented Oct 15, 2024

/ok to test

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vyasr
Copy link
Contributor

vyasr commented Oct 16, 2024

@a-hirota I've force-pushed to your branch removing all of the extraneous commits that were added here, hope you don't mind. The commit list is now just the two commits that you authored.

@vyasr
Copy link
Contributor

vyasr commented Oct 16, 2024

/ok to test

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Oct 16, 2024
@vyasr
Copy link
Contributor

vyasr commented Oct 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit c9202a0 into rapidsai:branch-24.12 Oct 16, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants