Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cudf-polars string/numeric casting #17076

Open
wants to merge 7 commits into
base: branch-24.12
Choose a base branch
from
Open

cudf-polars string/numeric casting #17076

wants to merge 7 commits into from
+78 −16

Conversation

brandon-b-miller
Copy link
Contributor

Depends on #16991
Part of #17060

Implements cross casting from string <-> numeric types in cudf-polars

@brandon-b-miller brandon-b-miller added feature request New feature or request non-breaking Non-breaking change cudf.polars Issues specific to cudf.polars labels Oct 14, 2024
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner October 14, 2024 16:05
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 14, 2024
Matt711
Matt711 reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some questions. And I think the PR needs the latests changes from branch-24.12.

python/cudf_polars/cudf_polars/dsl/expressions/unary.py Outdated Show resolved Hide resolved
python/cudf_polars/cudf_polars/dsl/expressions/unary.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 left review comments

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cudf.polars Issues specific to cudf.polars feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandon-b-miller @Matt711