Split cudf-polars AST validation and translation #20397
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `to_ast` and its usage to split up its validation function from its translation function. Closes rapidsai#20372
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
Python
TomAugspurger
added
improvement
TomAugspurger
commented
Oct 29, 2025
TomAugspurger
commented
Oct 29, 2025
TomAugspurger
commented
Oct 29, 2025
|
/ok to test eb45ee5 |
TomAugspurger
commented
Oct 30, 2025
|
/ok to test 8aede7e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes
to_astand its usage to split up its validation role from its translation role. The goal is to ensure that the translation, which makes pylibcudf Scalar objects, can be run in anIR.do_evaluatecontext with access to a CUDA stream.The major downside of this new implementation is the duplicated code between the validation and translation paths. Determining whether a particular operation is support isn't always trivial. I'll see whether that can be improved.
Closes #20372