Handle Empty child IRs in _decompose
#20409
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IndexErrorin_decomposewhen running pdsh query 17 with decimal data #20408I think what is happening is that during expression decomposition, we sometimes end up with a Cast node whose children are all literals. Those children produce
EmptyIR, so when_decomposefilters them out we end getting anIndexErrora few lines down.This PR makes it so we now reuse the parent’s input IR in that case.
I haven't been able to come up with a smaller repro, but PDS-H Q17, doesn't crash anymore.
Checklist