always generate a .py script for notebook tests, pin version of nbcon…

…vert explicitly
rapidsai · Oct 15, 2024 · 87a840f · 87a840f
1 parent 4d66d77
commit 87a840f
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 1 deletion.
diff --git a/ci/utils/nbtest.sh b/ci/utils/nbtest.sh
@@ -60,7 +60,7 @@ for nb in $*; do
     echo --------------------------------------------------------------------------------
     echo STARTING: ${NBNAME}
     echo --------------------------------------------------------------------------------
-    jupyter nbconvert --to script ${NBFILENAME} --output ${NBTMPDIR}/${NBNAME}-test
+    jupyter nbconvert --to python ${NBFILENAME} --output ${NBTMPDIR}/${NBNAME}-test
     echo "${MAGIC_OVERRIDE_CODE}" > ${NBTMPDIR}/tmpfile
     cat ${NBTESTSCRIPT} >> ${NBTMPDIR}/tmpfile
     mv ${NBTMPDIR}/tmpfile ${NBTESTSCRIPT}

diff --git a/conda/environments/all_cuda-118_arch-x86_64.yaml b/conda/environments/all_cuda-118_arch-x86_64.yaml
@@ -27,6 +27,7 @@ dependencies:
 - libraft-headers==24.12.*,>=0.0.0a0
 - librmm==24.12.*,>=0.0.0a0
 - nanobind>=0.2.0
+- nbconvert>=7.16
 - nbsphinx
 - nccl>=2.19
 - notebook>=0.5.0

diff --git a/conda/environments/all_cuda-121_arch-x86_64.yaml b/conda/environments/all_cuda-121_arch-x86_64.yaml
@@ -32,6 +32,7 @@ dependencies:
 - libraft-headers==24.12.*,>=0.0.0a0
 - librmm==24.12.*,>=0.0.0a0
 - nanobind>=0.2.0
+- nbconvert>=7.16
 - nbsphinx
 - nccl>=2.19
 - notebook>=0.5.0

diff --git a/conda/environments/all_cuda-124_arch-x86_64.yaml b/conda/environments/all_cuda-124_arch-x86_64.yaml
@@ -32,6 +32,7 @@ dependencies:
 - libraft-headers==24.12.*,>=0.0.0a0
 - librmm==24.12.*,>=0.0.0a0
 - nanobind>=0.2.0
+- nbconvert>=7.16
 - nbsphinx
 - nccl>=2.19
 - notebook>=0.5.0

diff --git a/dependencies.yaml b/dependencies.yaml
@@ -304,6 +304,7 @@ dependencies:
       - output_types: [conda, requirements]
         packages:
           - ipython
+          - nbconvert>=7.16
           - notebook>=0.5.0
       - output_types: [conda]
         packages: