Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scikit-learn compatibility to 1.2 #5141

Merged
merged 31 commits into from
Jan 26, 2023
Merged

Update Scikit-learn compatibility to 1.2 #5141

merged 31 commits into from
Jan 26, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jan 20, 2023

No description provided.

@dantegd dantegd added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 20, 2023
@github-actions github-actions bot added ci conda conda issue Cython / Python Cython or Python issue labels Jan 20, 2023
wphicks
wphicks reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick look-over to make review of the final PR faster. Looks good so far!

bdice
bdice reviewed Jan 20, 2023
View reviewed changes
python/cuml/tests/test_compose.py Outdated Show resolved Hide resolved
ci/test_python_singlegpu.sh Outdated Show resolved Hide resolved
@hcho3 hcho3 mentioned this pull request Jan 21, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request Jan 24, 2023
@hcho3
Upgrade Treelite to 3.1.0 (#5146)
085ef87 
Needed for #5141

Related: rapidsai/integration#589

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5146
@ajschmidt8
Copy link
Member

I just merged #5146, so I will update this PR to include the latest changes.

@dantegd dantegd marked this pull request as ready for review January 25, 2023 18:05
@dantegd dantegd requested review from a team as code owners January 25, 2023 18:05
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mmccarty
Copy link

Thoughts on scikit-learn backwards compatibility in dask/dask-ml#961

@github-actions github-actions bot removed the ci label Jan 26, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 69.26% // Head: 68.97% // Decreases project coverage by -0.30% ⚠️

Coverage data is based on head (b2b7737) compared to base (de32125).
Patch coverage: 91.11% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02    #5141      +/-   ##
================================================
- Coverage         69.26%   68.97%   -0.30%     
================================================
  Files               192      192              
  Lines             12333    12370      +37     
================================================
- Hits               8543     8532      -11     
- Misses             3790     3838      +48
Impacted Files Coverage Δ
python/cuml/testing/strategies.py 92.85% <90.47%> (-1.22%) ⬇️
...ing/text/stem/porter_stemmer_utils/suffix_utils.py 91.11% <100.00%> (+0.20%) ⬆️
python/cuml/neighbors/kernel_density.py 78.57% <0.00%> (-9.10%) ⬇️
python/cuml/feature_extraction/_vectorizers.py 84.38% <0.00%> (-5.65%) ⬇️
...party/sklearn/preprocessing/_column_transformer.py 72.99% <0.00%> (-1.95%) ⬇️
python/cuml/internals/array.py 87.35% <0.00%> (-0.80%) ⬇️
python/cuml/metrics/pairwise_kernels.py 80.31% <0.00%> (-0.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8
Copy link
Member

admin merging per request from @dantegd

@ajschmidt8 ajschmidt8 merged commit 79d0b9e into rapidsai:branch-23.02 Jan 26, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@hcho3
Upgrade Treelite to 3.1.0 (rapidsai#5146)
56d9a49 
Needed for rapidsai#5141

Related: rapidsai/integration#589

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5146
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@dantegd
Update Scikit-learn compatibility to 1.2 (rapidsai#5141)
1c2dbd1 
Authors:
   - Dante Gama Dessavre (https://github.com/dantegd)
   - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
   - William Hicks (https://github.com/wphicks)
   - AJ Schmidt (https://github.com/ajschmidt8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@hcho3 hcho3 hcho3 left review comments

@wphicks wphicks wphicks approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@dantegd dantegd

Labels
2 - In Progress Currenty a work in progress conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dantegd @ajschmidt8 @mmccarty @codecov-commenter @hcho3 @bdice @wphicks