Enable pytest failures on FutureWarnings/DeprecationWarnings #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a623a07.
This was referenced Apr 24, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Split from #5799 Non-integer arguments are deprecated to this method Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #5864
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Split from #5799 `distutils` will be removed in Python 3.12. For version parsing, other RAPIDS libraries use `packaging` so added as a dependency as well Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: #5868
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Split from #5799 `cupy.sparse` is deprecated in favor of `cupyx.scipy.sparse` Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #5867
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Split from #5799 * `product` -> `prod` * Coercing single element arrays to it's scalar value via `int` or similar appears deprecated, so adjusted not to do this where possible Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #5866
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Split from #5799 Non-keyword args are deprecated from these signatures so fixing them where used Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #5865
|
closed by #5877 |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 29, 2024
This is an attempt to update the scikit-learn dependency from 1.2 to 1.4. Most changes are related to constructor arguments that were deprecated in 1.2 and in 1.4 have changed/been removed. A question I have is what cuml's deprecation policy is? I've gone with "two releases" for parameters where we can easily do so (deprecated in 24.06 and then remove them in 24.10). However that is only about 4 months of deprecation which could be a bit short. Some of the changes would be hard to do as a deprecation (with 1.4 there is no way to provide the "old way"), we'd have to stick with 1.3 for now. I think this is a bit of a bummer but maybe the price to pay for not keeping on top of deprecations. And it seems like there is no deprecation policy in the docs/towards users? So maybe we can play this card once now, to catch up and at the same time introduce a deprecation policy. The SHAP test needed its reference updating. I am not sure why, at least I couldn't quickly find a reason for why you'd have to do this. I am not sure how possible it would be to support a range of scikit-learn versions (say 1.2 - 1.4). Would be cool but maybe not worth the added complexity? Todo: * [x] add deprecation warning in AgglomerativeClustering * [ ] add tests for deprecations * [x] RF regressor * [x] RF classifier * [ ] ~~LARS~~ - LARS is experimental, so no need for deprecation * [x] LogisticRegression * [x] OneHotEncoder * [x] AgglomerativeClustering * [ ] think about how to combine this with #5799 * [x] decide deprecation cycle length - copy cudf, so 24.06 -> 24.08 * [x] update "expiry" version in the warnings * [x] update doc strings xref #5799 Authors: - Tim Head (https://github.com/betatim) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Jake Awe (https://github.com/AyodeAwe) URL: #5851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite will now fail on
FutureWarnings andDeprecationWarnings as apart of rapidsai/build-planning#26.Also
pytest.iniwas consolidated intopyproject.tomlso there's only 1 place with these configsRequires #5819 and #5798 to be merged first