-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflowing in intersection_intermediates.remove_if
#1209
Merged
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/1200_p2
harrism
approved these changes
Jul 26, 2023
thomcom
approved these changes
Jul 28, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
libcuspatial
Relates to the cuSpatial C++ library
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EDIT: the thrust bug is a known issue. Tracked by NVIDIA/cccl#153
This PR fixes an issue in
remove_if
. Strangely, when callingreduce_by_key
with iterator to integer,and when using
thrust::plus<index_t>()
, even if by definition the argument type of the plus operator is strongly typedwith a higher bit width integer type, and I expected that the flags (
uint8_t
) were cast to the higherbit depth before addition, the overflow still happens. I have filed a thread in the thrust channel to discuss if this
is a bug in thrust.
Meanwhile, a quick WAR is to explicitly use a transform iterator to cast the uchar in to
index_t
before adding.This should give the correct result.
Fixes #1200
Depend on #1207
Checklist