Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip taxi notebook from CI #1420

Closed
wants to merge 10 commits into from

Conversation

harrism
Copy link
Member

@harrism harrism commented Jul 31, 2024

Description

#1407 skipped the taxi dropoffs notebook due to performance regression fixed in #1418, so this PR re-enables the notebook in CI by removing it from SKIPNBS in ci/test_noteboks.sh.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added conda Related to conda and conda configuration Python Related to Python code ci labels Jul 31, 2024
@harrism harrism added non-breaking Non-breaking change bug Something isn't working labels Jul 31, 2024
@harrism
Copy link
Member Author

harrism commented Jul 31, 2024

Wrong branch.

@harrism harrism closed this Jul 31, 2024
@harrism harrism deleted the fix-unskip-taxi-notebook branch July 31, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci conda Related to conda and conda configuration non-breaking Non-breaking change Python Related to Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants