-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure notebook-testing script fails when notebooks fail #1424
ensure notebook-testing script fails when notebooks fail #1424
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This is ready for review. The failing unit test jobs are unrelated... they're the result of #1427, which will hopefully be fixed by @mroeschke 's PR: #1428 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks James! 🙏
Looks good. Had one minor suggestion
Co-authored-by: jakirkham <[email protected]>
There were a couple CI jobs that appear to have had issues starting up (this is well before anything cuSpatial related AFAICT) Have gone ahead and restarted those failing jobs. Hopefully that clears out the issue |
/merge |
Thanks @jakirkham ! I think we'll need #1434 to be finished to unblock CI in this repo. |
One the notebooks is failing with what looks like a new |
Going to covert to draft for clarity while those other blockers get cleared out |
I think draft should be reserved for PRs unready for review. This PR is already reviewed, but can't be merged. I suggest using the DO NOT MERGE label, which does what it says on the tin. |
No problem, I've moved this back to |
Hopefully CI here will pass once #1438 is merged. |
Thanks so much for all the help, everyone! Sorry this took a couple iterations, but I think this testing is in a better state now. |
Description
The notebook-testing CI job in this repo does not actually cause a loud CI failure if any errors are detected in notebooks. That's because of a
bash
mistake I made in #1407... that PR moved notebook-checking into a function, but didn't add aset -E
to be sure errors from inside that function were appropriately trapped.This PR fixes that:
nyc_taxi_years_correlation.ipynb
codeContext: #1422 (review)
Notes for Reviewers
How I tested this
Originally did not skip any notebooks. Saw the failures in one of the notebooks cause an actual merge-blocking CI failure.
Build link: https://github.com/rapidsai/cuspatial/actions/runs/10199784404/job/28219162698?pr=1424
Checklist