Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal linkage kernels #1436

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Internal linkage kernels #1436

merged 7 commits into from
Aug 21, 2024

Conversation

robertmaynard
Copy link
Contributor

Description

Mark all cuspatial CUDA kernels with internal linkage to avoid runtime symbol collisions.

Also updated the CI tests to also verify that we add no new CUDA kernel with external linkage.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Non-breaking change labels Aug 8, 2024
@robertmaynard robertmaynard requested review from a team as code owners August 8, 2024 16:01
@robertmaynard robertmaynard mentioned this pull request Aug 8, 2024
Closed
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Aug 8, 2024
harrism
harrism approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion, but looks good! Thanks.

cpp/include/cuspatial/detail/point_linestring_nearest_points.cuh Outdated Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

/merge

bdice
bdice approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving CI changes.

@rapids-bot rapids-bot bot merged commit f678ad5 into rapidsai:branch-24.10 Aug 21, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@bdice bdice bdice approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/ci-codeowners

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
bug Something isn't working libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @harrism @bdice