Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data=None to ListColumn constructor #1442

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add data=None to ListColumn constructor #1442

merged 1 commit into from
Aug 21, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Post rapidsai/cudf#16465, the data argument to ListColumn is a required argument (as None)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner August 21, 2024 18:04
@github-actions github-actions bot added the Python Related to Python code label Aug 21, 2024
bdice
bdice approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If this passes tests we should be good to merge.

edit: I guess I'm not in cuspatial-python-codeowners...

@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Aug 21, 2024
@jameslamb jameslamb mentioned this pull request Aug 21, 2024
Merged
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5dd14ef into rapidsai:branch-24.10 Aug 21, 2024
58 checks passed
@mroeschke mroeschke deleted the fix/listcolumn/data branch August 21, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @bdice