Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable mixing libcuspatial wheels with libcudf conda packages #1456

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jameslamb
Copy link
Member

Description

Fixes #1455

devcontainer conda CI jobs are failing in this project because of the following mix of characteristics for thoes jobs:

  • all build and runtime dependencies for libcuspatial, cuspatial, cuproj are installed via conda
  • libcuspatial, cuspatial, and cuproj wheels are then built with pip install -e --no-deps --no-build-isolation
  • import libcuspatial results in unconditionally running import libcudf
  • libcudf is provided by the libcudf conda package, which does not have any Python modules, so that import fails

This fixes that, and restores the ability to mix a pip install'd cuspatial / cuproj with a conda-installed libcudf.

Notes for Reviewers

How did CI not catch this before?

When rapidsai/devcontainers#387 was merged, I only re-ran the pip devcontainers CI job on #1450.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added bug Something isn't working 2 - In Progress Currenty a work in progress non-breaking Non-breaking change labels Sep 5, 2024
@github-actions github-actions bot added the Python Related to Python code label Sep 5, 2024
@jameslamb jameslamb changed the title WIP: fix usage of libcuspatial wheels with libcudf conda packages WIP: re-enable mixing libcuspatial wheels with libcudf conda packages Sep 5, 2024
@jameslamb jameslamb changed the title WIP: re-enable mixing libcuspatial wheels with libcudf conda packages re-enable mixing libcuspatial wheels with libcudf conda packages Sep 5, 2024
@jameslamb jameslamb marked this pull request as ready for review September 5, 2024 22:49
@jameslamb jameslamb requested a review from a team as a code owner September 5, 2024 22:49
@bdice
Copy link
Contributor

bdice commented Sep 6, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9385e49 into rapidsai:branch-24.10 Sep 6, 2024
67 checks passed
@bdice
Copy link
Contributor

bdice commented Sep 6, 2024

Unblocks CI for #1453, so I merged this.

@jameslamb jameslamb deleted the fix/libcudf-import branch September 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress bug Something isn't working non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

[BUG]: conda devcontainers build failing: "No module named 'libcudf'"
2 participants