Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused variables in build_docs script #1469

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#106

This project doesn't need any of the changes that are being made as part of that issue across most other repos... it's already doing all of its pip and conda installs in CI in single installs (which is strict and safe) 🎉

This small PR just makes its handling of environment variables in ci/build_docs.sh consistent with other RAPIDS repos, in the interest of keeping those scripts looking similar so it's easy to apply changes across all RAPIDS projects. ref: rapidsai/cudf#17013 (comment)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 8, 2024
@github-actions github-actions bot added the ci label Oct 8, 2024
@jameslamb jameslamb changed the title WIP: remove unused variables in build_docs script remove unused variables in build_docs script Oct 8, 2024
@jameslamb jameslamb removed the 2 - In Progress Currenty a work in progress label Oct 8, 2024
@jameslamb jameslamb marked this pull request as ready for review October 8, 2024 23:29
@jameslamb jameslamb requested a review from a team as a code owner October 8, 2024 23:29
ci/build_docs.sh Outdated Show resolved Hide resolved
@jameslamb
Copy link
Member Author

I realized that RAPIDS_VERSION and RAPIDS_VERSION_MAJOR_MINOR need to be set in the environment by the build_docs script, because they're used for Doxygen.

PROJECT_NUMBER = $(RAPIDS_VERSION)

TAGFILES = rmm.tag=https://docs.rapids.ai/api/librmm/$(RAPIDS_VERSION_MAJOR_MINOR) "libcudf.tag=https://docs.rapids.ai/api/libcudf/$(RAPIDS_VERSION_MAJOR_MINOR)"

Just pushed a commit restoring them. I think the small diff left in this PR is still worth it, to replace a hard-coded version number with one that's driven by the VERSION file.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit c45ff5f into rapidsai:branch-24.12 Oct 11, 2024
75 checks passed
@jameslamb jameslamb deleted the ci-conda-installs branch October 11, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants