Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go API - [WIP] #212

Open
wants to merge 63 commits into
base: branch-25.02
Choose a base branch
from
Open

Go API - [WIP] #212

wants to merge 63 commits into from

Conversation

ajit283
Copy link
Contributor

@ajit283 ajit283 commented Jul 3, 2024

This PR adds a Go API. It's far from completion and still work in progress. Feel free to suggest improvements!

@ajit283 ajit283 requested a review from a team as a code owner July 3, 2024 19:57
Copy link

copy-pr-bot bot commented Jul 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CMake label Jul 3, 2024
@benfred benfred added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 3, 2024
@cjnolet
Copy link
Member

cjnolet commented Jul 9, 2024

/ok to test

@ajit283 ajit283 requested review from a team as code owners July 10, 2024 17:26
@ajit283 ajit283 requested a review from jameslamb July 10, 2024 17:26
@github-actions github-actions bot added the ci label Jul 10, 2024

rapids-dependency-file-generator \
--output conda \
--file-key go \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know how I could add this file key to rapids-dependency-file-generator?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bdice @vyasr @AyodeAwe any suggestions here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a key under files: in dependencies.yaml, then add dependency lists with the conda packages you need. Here’s the rust one for comparison:

rust:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More explanation in the README here: https://github.com/rapidsai/dependency-file-generator

go-build:
needs: cpp-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am I doing this correctly?

@cjnolet
Copy link
Member

cjnolet commented Nov 27, 2024

/ok to test

examples/c/CMakeLists.txt Outdated Show resolved Hide resolved
go/go.sum Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented Dec 5, 2024

/ok to test

@ajit283 ajit283 changed the base branch from branch-24.12 to branch-25.02 December 10, 2024 11:52
@cjnolet
Copy link
Member

cjnolet commented Dec 10, 2024

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 8, 2025

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 10, 2025

/ok to test

@benfred
Copy link
Member

benfred commented Jan 15, 2025

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jan 18, 2025

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants