Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.10 into branch-24.12 #385

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Oct 3, 2024

Forward-merge triggered by push to branch-24.10 that creates a PR to keep branch-24.12 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

@rapids-bot rapids-bot bot requested a review from a team as a code owner October 3, 2024 03:09
@github-actions github-actions bot added the cpp label Oct 3, 2024
Copy link
Author

rapids-bot bot commented Oct 3, 2024

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

For the cuml integration, we need to be able to statically link to cuvs in order build the python wheels. This change adds a static target that lets us do that

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #382
@rapids-bot rapids-bot bot requested a review from a team as a code owner October 3, 2024 13:06
@github-actions github-actions bot added the CMake label Oct 3, 2024
This PR implements a distributed (single-node-multiple-GPUs) implementation of ANN indexes. It allows to build, extend and search an index on multiple GPUs.

Before building the index, the user has to choose between two modes :

**Sharding mode** : The index dataset is split, each GPU trains its own index with its respective share of the dataset. This is intended to both increase the search throughput and the maximal size of the index.
**Index duplication mode** : The index is built once on a GPU and then copied over to others. Alternatively, the index dataset is sent to each GPU to be built there. This intended to increase the search throughput.

SNMG indexes can be serialized and de-serialized. Local models can also be deserialized and deployed in index duplication mode.

![bench](https://github.com/user-attachments/assets/e313d0ef-02eb-482a-9104-9e1bb400456d)

Migrated from rapidsai/raft#1993

Authors:
  - Victor Lafargue (https://github.com/viclafargue)
  - James Lamb (https://github.com/jameslamb)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)
  - James Lamb (https://github.com/jameslamb)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #231
@rapids-bot rapids-bot bot requested review from a team as code owners October 3, 2024 18:10
@rapids-bot rapids-bot bot requested a review from msarahan October 3, 2024 18:10
benfred and others added 2 commits October 3, 2024 15:28
Seeing build errors in the cuml wheels, and the only difference afaict
was adding the cuvs-cagra-search to link to the static library.

Removing this since cuml is the only consumer of the static library this
release and doesn't use cagra (will revisit in 24.12)
Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #246
@rapids-bot rapids-bot bot requested a review from a team as a code owner October 3, 2024 20:30
@github-actions github-actions bot added the Python label Oct 3, 2024
cjnolet and others added 3 commits October 3, 2024 15:46
Adding documentation for each index type. This decouples the major
details in the docs from the individual language API docs to present
users with a better overal experience. The major topcs in the new
index-level docs are meant to be more exhaustive than the API docs in
providing

1. Description of each index type, when it's useful and shortcomings
2. Links to any relevant research material to learn more foundational
info
3. Hyper-parameters
4. Links to API docs for each supported language
5. Links to example projects and notebooks
6. Formulas for rough estimates of memory footprint
7. How to use in cuvs-bench, along with some rough benchmarks on
different hardware

---------

Co-authored-by: Micka <[email protected]>
Builds upon #367

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Bradley Dice (https://github.com/bdice)

URL: #368
@rapids-bot rapids-bot bot requested a review from a team as a code owner October 4, 2024 00:40
@github-actions github-actions bot added the ci label Oct 4, 2024
benfred and others added 2 commits October 4, 2024 12:54
Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #395
This PR adds some critical doc fixes for 24.10- 

1. Since we're working on the Nvidia developer landing page for cuVS,
our README content needs to be aligned.
2. The cuvs-bench documentation was missing the datasets guide and table
of contents.
3. The cuvs-bench docs weren't linked into the main docs. 
4. cuvs-bench was missing several of the mg enabled algorithms, their
constraints, and parameter ranges.

---------

Co-authored-by: Micka <[email protected]>
Co-authored-by: viclafargue <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (branch-24.12@d093986). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-24.12     #385   +/-   ##
===============================================
  Coverage                ?   71.42%           
===============================================
  Files                   ?       13           
  Lines                   ?       56           
  Branches                ?        0           
===============================================
  Hits                    ?       40           
  Misses                  ?       16           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benfred
Copy link
Member

benfred commented Oct 10, 2024

manual forward merge #407

@AyodeAwe AyodeAwe merged commit 0f2f933 into branch-24.12 Oct 10, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants