-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add click
package to cuvs-bench
conda recipe
#408
base: branch-24.12
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this so you can merge this if it's time-sensitive, but I do have a suggestion.
Seeing a run-time dependency missed made me think "how could this not have been caught by tests"? And it looks like the answer is "there aren't any tests run in CI".
Would you please consider adding some tests on this package in https://github.com/rapidsai/cuvs/blob/branch-24.12/ci/test_python.sh?
I know this is a little different than other libraries because it's for benchmarking, but you could for example add a test like this one that all the other RAPIDS libraries have:
and then a test like this:
That's be a cheap and lightweight way to at least minimally test that the package is installable and importable. It might not have caught this specific issue because click
is probably somewhere in the dependency tree of other packages, but it would catch this type of problem for other dependencies, and give us higher confidence in releases.
@jameslamb fully agree with your comment, adding tests is in the backlog and something I've wanted to get to as bandwidth permits. I even added unit code pytests, but haven't had time to fully check them and enable them, it something we plan to do as soon as we can alongside as benchmarks like you suggest in a follow up :) |
@jameslamb we have a test suite that we'll be focussing on getting ready this release https://github.com/rapidsai/cuvs/tree/branch-24.12/python/cuvs_bench/cuvs_bench/tests. Until then, if it's okay with you, let's merge this PR. |
Yeah totally fine.
Sure, I understand. I think it'd be worth adding something lightweight like the You're not getting that kind of coverage from Lines 35 to 39 in f62b217
|
This package is available in
dependencies.yaml
, but due to an oversight was not added to conda metas.