Port C++ CAGRA runtime from RAFT #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Ide <[email protected]>
cjnolet
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Looking great so far! I wanted to share some initial feedback early.
I think we should go ahead and remove all of the headers from the detail namespace and any of the public headers that we're not using. I had originally copied the entire RAFT repo over thinking it might be easy just to rename the VSS bits but it proved harder than I had hoped.
cpp/test/CMakeLists.txt
Outdated
| src/neighbors/detail/cagra/search_single_cta_float_uint64_dim512_t32.cu | ||
| src/neighbors/detail/cagra/search_single_cta_float_uint64_dim1024_t32.cu | ||
| #test/neighbors/ann_cagra/test_float_int64_t.cu | ||
| #src/neighbors/detail/cagra/search_multi_cta_float_uint64_dim128_t8.cu |
There was a problem hiding this comment.
We should move the relevant tests over so that we can test end-to-end w/ the new cuvs::neighbors public API.
There was a problem hiding this comment.
I kept test/neighbors/ann_cagra to test end-to-end CAGRA
cjnolet
added
improvement
Signed-off-by: Mickael Ide <[email protected]>
|
Changes have been merged into #27. Closing this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is porting the CAGRA runtime API from RAFT to cuVS.