fix(deps): relax bokeh upper pin, update custom TS usage
#731
Conversation
gforsyth
added
improvement
…trictions "custominspect" isn't a valid type for the alias. Also, we don't need it (says Cursor) b.c. we can use it directly as a `CustomInspectTool` instance. In any case, I was able to run previously failing example charts after making this change.
|
I fixed and updated some docstring formatting because I thought warnings were getting escalated to errors -- the actual issue was in some stricter Typescript types in newer version of Bokeh. That was fixed by removing the I can rip out the docstring fixes if we want to keep this PR more tightly scoped. |
gforsyth
changed the title
bokeh upper pinbokeh upper pin, update custom TS usage
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Gil! 🙏
Fixed one conflict related to file header changes from PR: #734
Though noticed there are a few more places we likely want these changes
cc @KyleFromNVIDIA (to check we are capturing these correctly)
python/cuxfilter/charts/datashader/custom_extensions/graph_inspect_widget.py
Outdated
Show resolved
Hide resolved
|
Kyle submitted PR ( #736 ) for the SPDX changes Have tried to resolve the conflicts it introduced with this PR Looks like that captures the header changes that were originally being made here Though please double check and make sure this looks ok |
|
My PR based its headers off of |
There was a problem hiding this comment.
CI passing for the changes made in this PR is just api level confirmation. We still need some confirmation that the dashboards work in notebooks and colab, has that been tried @gforsyth ?
|
No, I haven't checked that -- probably better if someone familiar with the package takes a look so they can verify the outputs. |
4 participants
Trying to relax the upper pin for
bokehto see what happens in CI.We currently pin
bokehto>3.1,<=3.6independencies.yamlbut not in therattler-buildrecipe, so we are testing a different dependency set than the one that a user will get if they install usingconda.Fixes #728