Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify markdownlint configuration #436

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

jameslamb
Copy link
Member

#74 introduced an empty .markdownlintignore file, and that file appears to have been empty ever since.

I think it's safe to remove, and that doing so would slightly simplify this repo.

This proposes that removal.

Notes for Reviewers

Let's not merge until @jacobtomlinson specifically reviews... there might be some context I'm missing that explains why this empty file was added back in #74.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 3, 2024
@jameslamb jameslamb requested a review from a team as a code owner October 3, 2024 17:26
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I added this just for future use. The pre-commit example probably just included the args that specified it and I added an empty file for good measure.

I have no strong feelings either way on removing it.

@jameslamb
Copy link
Member Author

Alright thanks! I think we should remove it then, to simplify things a bit.

@jacobtomlinson jacobtomlinson merged commit 24d842e into rapidsai:main Oct 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants