Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Infiniband Updated Ubuntu Versions #462

Merged
merged 19 commits into from
Oct 14, 2024
Merged

Conversation

melodywang060
Copy link
Contributor

@melodywang060 melodywang060 commented Oct 10, 2024

Problem 1

On the guide it says to select the Ubuntu Server 20.04 image, but this image is outdated and not available anymore.

Quick Fix

Replace with the newest version Ubuntu Server 24.04

Problem 2

This command wget https://developer.download.nvidia.com/compute/cuda/repos/$distribution/x86_64/cuda-keyring_1.0-1_all.deb yields a 404 NOT FOUND error because cuda-keyring_1.0-1_all.deb does not exist anymore

Quick Fix

Replace with the latest version, cuda-keyring_1.1-1_all.deb

Problem 3

In this command, sudo apt-get install -y automake dh-make git libcap2 libnuma-dev libtool make pkg-config udev curl librdmacm-dev rdma-core \ libgfortran5 bison chrpath flex graphviz gfortran tk dpatch quilt swig tcl ibverbs-utils

the dpatch package does not exist anymore - is there a replacement or can we just delete this requirement?

Quick Fix

Problem 4

Users who are not too aware of running conda init might exit out of the shell first.

Quick Fix

Adding a line that demonstrates how to enable conda and restart shell will clarify potential confusions users may have.

@melodywang060 melodywang060 requested a review from a team as a code owner October 10, 2024 18:22
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some small suggestions, but none of them need to block merging.

I don't know why dpatch was in this example, but if you ran the entire example end-to-end and it succeeded without it, I'm confident it can be removed.

source/cloud/azure/aks.md Outdated Show resolved Hide resolved
source/guides/azure/infiniband.md Outdated Show resolved Hide resolved
@melodywang060
Copy link
Contributor Author

thanks @jameslamb !

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks @melodywang060 (and @jameslamb for review)

@jacobtomlinson jacobtomlinson merged commit 44ce014 into main Oct 14, 2024
3 of 4 checks passed
@jacobtomlinson jacobtomlinson deleted the azure-infiniband branch October 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants