Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sphinx upper-bound with sphinx-mermaid lower-bound #474

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Replace sphinx upper-bound with sphinx-mermaid lower-bound #474

merged 1 commit into from
Oct 14, 2024

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Oct 14, 2024 •
edited
Loading

Reverts #470 and replaces the upper-bound on sphinx with a lower-bound on sphinx-mermaid.

@jacobtomlinson jacobtomlinson requested a review from a team as a code owner October 14, 2024 11:05
jameslamb
jameslamb approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been following the conversation in mgaitan/sphinxcontrib-mermaid#160 and similar, this seems like the right fix. Thanks!

@jameslamb jameslamb merged commit 37a3135 into rapidsai:main Oct 14, 2024
3 checks passed
@jacobtomlinson jacobtomlinson deleted the sphinx-mermaid-bump branch October 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@melodywang060 melodywang060 melodywang060 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobtomlinson @jameslamb @melodywang060