[REVIEW] IO Patch 1

[BradReesWork]

No description provided.

[scopatz]

Seems to fail to build

12:57:34 [100%] Generating libgdf_cffi/libgdf_cffi.py
12:57:34 Traceback (most recent call last):
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/cparser.py", line 269, in _parse
12:57:34     ast = _get_parser().parse(csource)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/pycparser/c_parser.py", line 151, in parse
12:57:34     debug=debuglevel)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/pycparser/ply/yacc.py", line 331, in parse
12:57:34     return self.parseopt_notrack(input, lexer, debug, tracking, tokenfunc)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/pycparser/ply/yacc.py", line 1181, in parseopt_notrack
12:57:34     tok = call_errorfunc(self.errorfunc, errtoken, self)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/pycparser/ply/yacc.py", line 193, in call_errorfunc
12:57:34     r = errorfunc(token)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/pycparser/c_parser.py", line 1721, in p_error
12:57:34     column=self.clex.find_tok_column(p)))
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/pycparser/plyparser.py", line 55, in _parse_error
12:57:34     raise ParseError("%s: %s" % (coord, msg))
12:57:34 pycparser.plyparser.ParseError: :33:58: before: csr_gdf
12:57:34 
12:57:34 During handling of the above exception, another exception occurred:
12:57:34 
12:57:34 Traceback (most recent call last):
12:57:34   File "setup.py", line 8, in <module>
12:57:34     install_requires=["cffi>=1.0.0"],
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/distutils/core.py", line 108, in setup
12:57:34     _setup_distribution = dist = klass(attrs)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/setuptools/dist.py", line 318, in __init__
12:57:34     _Distribution.__init__(self, attrs)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/distutils/dist.py", line 281, in __init__
12:57:34     self.finalize_options()
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/setuptools/dist.py", line 375, in finalize_options
12:57:34     ep.load()(self, ep.name, value)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/setuptools_ext.py", line 188, in cffi_modules
12:57:34     add_cffi_module(dist, cffi_module)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/setuptools_ext.py", line 49, in add_cffi_module
12:57:34     execfile(build_file_name, mod_vars)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/setuptools_ext.py", line 25, in execfile
12:57:34     exec(code, glob, glob)
12:57:34   File "libgdf_cffi/libgdf_build.py", line 8, in <module>
12:57:34     ffibuilder.cdef(fin.read())
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/api.py", line 106, in cdef
12:57:34     self._cdef(csource, override=override, packed=packed)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/api.py", line 120, in _cdef
12:57:34     self._parser.parse(csource, override=override, **options)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/cparser.py", line 308, in parse
12:57:34     self._internal_parse(csource)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/cparser.py", line 313, in _internal_parse
12:57:34     ast, macros, csource = self._parse(csource)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/cparser.py", line 271, in _parse
12:57:34     self.convert_pycparser_error(e, csource)
12:57:34   File "/home/jenkins/.conda/envs/libgdf_dev/lib/python3.5/site-packages/cffi/cparser.py", line 300, in convert_pycparser_error
12:57:34     raise CDefError(msg)
12:57:34 cffi.error.CDefError: cannot parse "gdf_error gdf_to_csr(gdf_column **gdfData, int num_cols, csr_gdf *csrReturn);"
12:57:34 :33:58: before: csr_gdf

[BradReesWork]

Looking into build issue

[nsakharnykh]

I see this when compiling with CUDA 10:

                 from .../libgdf/src/io/csv/csv-reader.cu:50:
/usr/local/cuda/include/math_functions.h:54:2: error: #warning "math_functions.h is an internal header file and must not be used directly.  This file will be removed in a future CUDA release.  Please use cuda_runtime_api.h or cuda_runtime.h instead." [-Werror=cpp]
 #warning "math_functions.h is an internal header file and must not be used directly.  This file will be removed in a future CUDA release.  Please use cuda_runtime_api.h or cuda_runtime.h instead."
  ^

Also, when commenting out math_functions.h I hit another warning:
libgdf/src/io/csv/csv-reader.cu(118): warning: conversion from pointer to smaller integer
Can we include those fixes in this patch?

[BradReesWork]

yep. I can fix those two issues