Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use memory resource in DeviceBuffer #1132

Draft
wants to merge 4 commits into
base: branch-23.06
Choose a base branch
from
Draft

Use memory resource in DeviceBuffer #1132

wants to merge 4 commits into from

Commits on Oct 18, 2022

  1. Use device_buffer constructors w/memory resource 

    Update the C++ constructors to take `device_memory_resource` arguments.
This means that this argument is now required (at least based on the
constructors defined here) when calling `device_buffer` constructors.
    @jakirkham
    jakirkham committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    fb75182 View commit details
    Browse the repository at this point in the history

  2. Use memory resource in DeviceBuffer construtor 

    Update the Python constructor to take and handle a
`DeviceMemoryResource` argument. Also pass this through to
`device_buffer` constructors.
    @jakirkham
    jakirkham committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    548b353 View commit details
    Browse the repository at this point in the history

  3. Accept memory resource (and stream) in copy 

    Changes `copy` to allow a memory resource to be specified (using the
default device memory resource if unspecified). Also accepts a `stream`
argument (similar to other functions).
    @jakirkham
    jakirkham committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    c777637 View commit details
    Browse the repository at this point in the history

  4. Add memory resource argument through to_device 

    While the `to_device` function already included a memory resource, it
didn't use it. Plus other functions calling `to_device` did not use the
argument. The change here makes sure `to_device` passes this to the
`DeviceBuffer` constructor. Also it makes sure other functions have a
default argument, which they set if one is not specified.
    @jakirkham
    jakirkham committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    a66a255 View commit details
    Browse the repository at this point in the history