-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code paths that depend on RMM_STATIC_CUDART #1667
base: branch-24.10
Are you sure you want to change the base?
Remove code paths that depend on RMM_STATIC_CUDART #1667
Conversation
Are existing tests sufficient to cover this? |
I will add explicit tests that control the type of cudart we are using to verify these chages |
a136228
to
326fd58
Compare
326fd58
to
4866138
Compare
Did more testing today and realize that more work is needed. With this PR we are getting all the symbols required at link time, but the dlsym with Need more time to figure out what is going wrong. |
In what contexts is this failing? I assume it's a statically linked case, so the symbols cannot have been (dynamically) loaded with |
Description
We can remove the optimizations around
CUDA_STATIC_RUNTIME
and instead see if the function is already in the process space so that RMM doesn't need to have any build context to run properlyFixes #1679
Checklist