Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only match .yaml files in update-version.sh #132

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

raydouglass
Copy link
Member

Since there are no .yml files in .github/workflows, the final FILE will be the literal .github/workflows/*.yml which is passed to sed_runner and fails.

Other repos do not try to match both extensions, but if we want to do that here, it would be more complex code using find and a read-while loop.

@raydouglass raydouglass added bug Something isn't working non-breaking Introduces a non-breaking change labels Sep 22, 2023
@raydouglass raydouglass self-assigned this Sep 22, 2023
@raydouglass raydouglass changed the title Only match .yaml files Only match .yaml files in update-version.sh Sep 22, 2023
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

I think this repo used to have both extensions, but we made them consistent when we were redoing some of the wheel workflows.

@raydouglass raydouglass merged commit 264edf7 into branch-23.10 Sep 22, 2023
@raydouglass raydouglass deleted the match-yaml branch September 22, 2023 13:27
@vyasr
Copy link
Contributor

vyasr commented Sep 22, 2023

Yup see @ajschmidt8's request in #97 (comment), and also in #116. The .yml files were removed in #120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants