Add back wheels test job for Python 3.11, amd64, CUDA 12. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of #184. We found that wheel tests were failing due to a lack of proper support for "pure" Python wheels (independent of Python version and arch). Adding back the Python 3.11, amd64, CUDA 12 job will temporarily fix this (by making the "latest Python/CUDA" matrix filter used for wheel tests match the same configuration as the wheel build jobs).
We will need to change the
gha-toolsscripts to better handle pure Python wheels that should not have a Python version in their tarball names for upload/download.#187 will fix an underlying cause of this issue (we didn't notice that the
compute-matrixjob had an empty matrix because it passed in #184).