Add changed-files workflow
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2024
KyleFromNVIDIA
commented
Aug 30, 2024
bdice
approved these changes
Sep 17, 2024
| run: | ||
| shell: bash | ||
|
|
||
| permissions: |
There was a problem hiding this comment.
Review this. Do we need “read” on packages?
There was a problem hiding this comment.
Probably not. I'm also questioning whether we need id-token: write.
Requesting input from @ajschmidt8.
There was a problem hiding this comment.
We can revisit this later. I'll go ahead and merge.
There was a problem hiding this comment.
Probably not. I'm also questioning whether we need
id-token: write.Requesting input from @ajschmidt8.
No, id-token: write is not necessary here. It's only needed in workflows that require AWS credentials via aws-actions/configure-aws-credentials.
Can this branch be deleted now that the PR is merged?
There was a problem hiding this comment.
I went ahead and deleted it.
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Sep 26, 2024
Contributes to rapidsai/build-planning#94 Depends on rapidsai/shared-workflows#239 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #16713
copy-pr-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Sep 28, 2024
Contributes to rapidsai/build-planning#94 Depends on rapidsai/shared-workflows#239 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #16713
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Oct 1, 2024
Only run tests based on things that have actually changed. For example, if only Python files have changed, we don't need to run the C++ tests. Contributes to rapidsai/build-planning#94 Depends on rapidsai/shared-workflows#239 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Jake Awe (https://github.com/AyodeAwe) URL: #4634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for the "figure out which files changed" workflow is rather complex. Establish a shared workflow to handle the complexity of it.
Contributes to rapidsai/build-planning#94
Tested in rapidsai/cugraph#4634 and rapidsai/cudf#16713