Signal the worker progress event from the worker progress thread #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without signaling the worker progress event from the worker progress thread while shutting down the thread it may occur that the thread hangs as the event never gets awaken due to the lack of tasks to progress. This change ensures the worker progress event is signaled before joining the thread.
pentschev
added
bug
wence-
approved these changes
Apr 11, 2023
Although that said, it looks like the test suite segfaulted? |
It didn't segfault, it timed out. I can reproduce that locally and it's hitting #15 , although in CI it seems to hang indefinitely. That issue is not related to this PR specifically and is happening since we added CI. I'm still investigating it but going to go ahead and merge this when CI passes, as it fixed timeouts when running C++ examples. Thanks @wence- ! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without signaling the worker progress event from the worker progress thread while shutting down the thread it may occur that the thread hangs as the event never gets awaken due to the lack of tasks to progress. This change ensures the worker progress event is signaled before joining the thread.