Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for pylibwholegraph #40

Merged
merged 10 commits into from
Jul 25, 2023

Conversation

tingyu66
Copy link
Member

No description provided.

@tingyu66 tingyu66 requested a review from a team as a code owner July 20, 2023 00:20
@tingyu66 tingyu66 marked this pull request as draft July 20, 2023 00:20
@vyasr
Copy link
Contributor

vyasr commented Jul 21, 2023

Would recommend holding off on this until rapidsai/shared-workflows#116 is merged so that you can use the new workflows for wheels.

Separate question regarding the driver API usage, what APIs does wholegraph use and how new are they? Because if wholegraph requires a fairly new libcuda.so it's worth noting that the UX for installing the wheel into an environment with an older driver will be quite bad since there's really no way for us to constrain that. I imagine it'll fail to load the library correctly at runtime.

@tingyu66
Copy link
Member Author

Would recommend holding off on this until rapidsai/shared-action-workflows#116 is merged so that you can use the new workflows for wheels.

Thanks. I have migrated the script based on the new wheel build workflow. I have excluded the driver library from auditwheel repair and wheel build and the test has passed in CI.

Separate question regarding the driver API usage, what APIs does wholegraph use and how new are they? Because if wholegraph requires a fairly new libcuda.so it's worth noting that the UX for installing the wheel into an environment with an older driver will be quite bad since there's really no way for us to constrain that. Assuming that it's linked to a particular SOVERSION it also won't be able to leverage anything except the same driver version it was built with.

I am probably not the best person to answer this, as @dongxuy04 is the main developer. But to my knowledge, the memory management functions used here are not new in the drivers API.

@tingyu66 tingyu66 marked this pull request as ready for review July 24, 2023 20:13
@dongxuy04
Copy link
Contributor

Would recommend holding off on this until rapidsai/shared-action-workflows#116 is merged so that you can use the new workflows for wheels.

Thanks. I have migrated the script based on the new wheel build workflow. I have excluded the driver library from auditwheel repair and wheel build and the test has passed in CI.

Separate question regarding the driver API usage, what APIs does wholegraph use and how new are they? Because if wholegraph requires a fairly new libcuda.so it's worth noting that the UX for installing the wheel into an environment with an older driver will be quite bad since there's really no way for us to constrain that. Assuming that it's linked to a particular SOVERSION it also won't be able to leverage anything except the same driver version it was built with.

I am probably not the best person to answer this, as @dongxuy04 is the main developer. But to my knowledge, the memory management functions used here are not new in the drivers API.

@vyasr the Driver APIs used by wholegraph are virtual memory management APIs, like cuMemCreate, cuMemMap, cuMemAddressReserve, cuMemSetAccess, cuMemUnmap, cuMemRelease, cuMemAddressFree, and also IPC APIs like cuMemExportToShareableHandle, cuMemImportFromShareableHandle. I think they are supported from CUDA 11.0.

@BradReesWork BradReesWork added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 25, 2023
@BradReesWork BradReesWork added this to the 23.08 milestone Jul 25, 2023
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e5168c5 into rapidsai:refactoring Jul 25, 2023
22 of 23 checks passed
@tingyu66 tingyu66 deleted the wheel_build branch July 26, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants