Remove docs/ from Check version consistency in ci.yml#491
Merged
arferreira merged 2 commits intomainfrom Apr 13, 2026
Merged
Conversation
arferreira
changed the title
arferreira
added
the
github_actions
arferreira
reviewed
Apr 13, 2026
Collaborator
arferreira
left a comment
arferreira
left a comment
There was a problem hiding this comment.
I guess we shouldn't drop docs/ altogether.
.github/workflows/ci.yml
Outdated
| VERSION=$(grep '^version' rapina/Cargo.toml | head -1 | sed 's/.*"\(.*\)"/\1/') | ||
| MINOR="${VERSION%.*}" | ||
| BAD=$(grep -rn 'rapina = { version = "' docs/ rapina/examples/ \ | ||
| BAD=$(grep -rn 'rapina = { version = "' rapina/examples/ \ |
Collaborator
There was a problem hiding this comment.
I think this is too broad, I mean removing docs entirely means guides and tutorials as well. The problem is only with blog posts.
Suggested change
| BAD=$(grep -rn 'rapina = { version = "' rapina/examples/ \ | |
| BAD=$(grep -rn 'rapina = { version = "' docs/ rapina/examples/ --exclude-dir="blog" \ |
ShiraiEd
force-pushed
the
update/excludes-ci-docs-check
branch
from
ffd91cf to
8befc29
Compare
…oes not block new release notes
ShiraiEd
force-pushed
the
update/excludes-ci-docs-check
branch
from
8befc29 to
61c29a0
Compare
arferreira
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove "docs/" from the "Check version consistency" in the ci.tml so the new release notes doesn't get blocked by
the outdated versions documented in there
Related Issues
Closes #490
Checklist
cargo fmtpassescargo clippyhas no warnings