Skip to content

Conversation

@rubix-coder
Copy link

To ease the understanding of each statement while referencing with the lecture video, comments are added.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

"metadata": {},
"outputs": [
{
"name": "stdout",
Copy link
Owner

@rasbt rasbt Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this PR. The comments here in this cell look good, but I see that there are also changes in other places.

I prefer not to merge the other changes here.


Reply via ReviewNB

@rubix-coder
Copy link
Author

Thank you for responding. I will be reviewing my changes and make sure the notebook is not disturbed much.
I would like to know if it is okay to update the torch and tiktoken version to latest (yr.2025) ?

@rasbt
Copy link
Owner

rasbt commented Dec 3, 2025

No problem.

I would like to know if it is okay to update the torch and tiktoken version to latest (yr.2025) ?

Sure, that's fine. But since your changes are only comments, I think it would be easiest to just apply the comments to the original notebook without rerunning the notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants