-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jaccard, Certainty, and Kulczynski association rules metrics #1099
Conversation
Remove centered confidence metric
Nachiket Deo <[email protected]>
Co-authored-by: Nachiket18 <[email protected]> Co-authored-by: AnkithN <[email protected]>
Co-authored-by: AnkithN <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @rasbt, we're looking at the failed formatting test case. The suggested formatting seems to be strange. It looks like it is taking issue with two lines in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, this looks pretty good to me!
Thanks for the PR. I am totally fine with not changing the formatting as suggested by black here. Let's see if this can be achieved via an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the small formatting modifications! Thanks again for the PR, looks really good!
Thanks @rasbt for reviewing and approving the change. It was fun to contribute to the library! |
Thanks @rasbt for approving and reviewing our change! It was a great experience to contribute to this library! |
Thank you @rasbt! It was great working with you on this change. We hope to continue contributing to your library in the future! |
Description
We have implemented three association rules metrics: Jaccard Coefficient, Certainty Factor, and Kulczynski.
We have added appropriate test cases for each of these metrics.
We have also added an optional parameter to
association_rules
, calledreturn_metrics
. The user can pass in a list of metrics for the function to return, rather than having the function generate every implemented metric.Related issues or pull requests
Resolves #1096
Pull Request Checklist
./docs/sources/CHANGELOG.md
file (if applicable)./mlxtend/*/tests
directories (if applicable)mlxtend/docs/sources/
(if applicable)PYTHONPATH='.' pytest ./mlxtend -sv
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv
)flake8 ./mlxtend