build: Upgrade to Rust 1.70 and fix new clippy warnings

Signed-off-by: Alexander Gil <[email protected]>

Cargo.toml

@@ -8,7 +8,7 @@ members = [
 [workspace.package]
 version = "1.8.6"
 authors = ["Pando85 <[email protected]>"]
-rust-version = "1.67"
+rust-version = "1.70"
 edition = "2021"
 license-file = "LICENSE"
 homepage = "https://rash.sh"

Dockerfile

@@ -1,4 +1,4 @@
-ARG BASE_IMAGE=rust:1.67.0
+ARG BASE_IMAGE=rust:1.70.0
 FROM ${BASE_IMAGE} AS builder
 LABEL mantainer [email protected]
 

rash_core/src/docopt/mod.rs

@@ -189,7 +189,6 @@ pub fn parse(file: &str, args: &[&str]) -> Result<Vars> {
 fn parse_help(file: &str) -> String {
     let re = Regex::new(r"#(.*)").unwrap();
     file.split('\n')
-        .into_iter()
         // skip first empty line cause split
         .skip(1)
         .map_while(|line| re.captures(line))

rash_core/src/docopt/options.rs

@@ -246,7 +246,6 @@ impl Options {
     pub fn parse_doc(doc: &str, usages: &[String]) -> Result<Self> {
         let mut description_options = Options::new(
             doc.split('\n')
-                .into_iter()
                 .filter_map(|line| {
                     let trimmed = line.trim_start();
                     if trimmed.starts_with('-') {

rash_core/src/modules/find.rs

@@ -55,19 +55,15 @@ use strum_macros::{Display, EnumString};
 #[derive(Debug, PartialEq, Deserialize)]
 #[cfg_attr(feature = "docs", derive(EnumString, Display, JsonSchema))]
 #[serde(rename_all = "lowercase")]
+#[derive(Default)]
 enum FileType {
     Any,
     Directory,
+    #[default]
     File,
     Link,
 }
 
-impl Default for FileType {
-    fn default() -> Self {
-        FileType::File
-    }
-}
-
 fn default_file_type() -> Option<FileType> {
     Some(FileType::default())
 }
@@ -206,7 +202,6 @@ fn find(params: Params) -> Result<ModuleResult> {
         .git_ignore(!params.hidden.unwrap())
         .git_exclude(!params.hidden.unwrap())
         .build()
-        .into_iter()
         .map(|dir_entry| dir_entry.map_err(|e| Error::new(ErrorKind::Other, e)))
         .collect::<Result<Vec<_>>>()?
         .into_iter()