Skip to content
Commitlint

docs: Add dotfile description #1058

Sign in to view logs

docs: Add dotfile description

docs: Add dotfile description #1058

GitHub Actions / clippy succeeded Jun 27, 2023 in 1s

clippy

8 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 8
Note 0
Help 0

Versions

  • rustc 1.70.0 (90c541806 2023-05-31)
  • cargo 1.70.0 (ec8a8a0ca 2023-04-25)
  • clippy 0.1.70 (90c5418 2023-05-31)

Annotations

Check warning on line 209 in rash_core/src/modules/find.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `ignore::Walk` 

warning: useless conversion to the same type: `ignore::Walk`
   --> rash_core/src/modules/find.rs:191:31
    |
191 |       let result: Vec<String> = walk_builder
    |  _______________________________^
192 | |         // safe unwrap: default value defined
193 | |         .max_depth(match params.recurse.unwrap() {
194 | |             false => Some(1),
...   |
208 | |         .build()
209 | |         .into_iter()
    | |____________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing `.into_iter()`
    |
191 ~     let result: Vec<String> = walk_builder
192 +         // safe unwrap: default value defined
193 +         .max_depth(match params.recurse.unwrap() {
194 +             false => Some(1),
195 +             true => None,
196 +         })
197 +         // safe unwrap: default value defined
198 +         .follow_links(params.follow.unwrap())
199 +         // this prevents about unbounded feedback loops
200 +         .skip_stdout(true)
201 +         // safe unwrap: default value defined
202 +         // hidden criterion is opposite for params than for ignore library
203 +         .hidden(!params.hidden.unwrap())
204 +         .ignore(!params.hidden.unwrap())
205 +         .git_global(!params.hidden.unwrap())
206 +         .git_ignore(!params.hidden.unwrap())
207 +         .git_exclude(!params.hidden.unwrap())
208 +         .build()
    |

Check warning on line 69 in rash_core/src/modules/find.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived 

warning: this `impl` can be derived
  --> rash_core/src/modules/find.rs:65:1
   |
65 | / impl Default for FileType {
66 | |     fn default() -> Self {
67 | |         FileType::File
68 | |     }
69 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it...
   |
58 + #[derive(Default)]
59 | enum FileType {
   |
help: ...and mark the default variant
   |
61 ~     #[default]
62 ~     File,
   |

Check warning on line 192 in rash_core/src/docopt/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::str::Split<'_, char>` 

warning: useless conversion to the same type: `std::str::Split<'_, char>`
   --> rash_core/src/docopt/mod.rs:191:5
    |
191 | /     file.split('\n')
192 | |         .into_iter()
    | |____________________^ help: consider removing `.into_iter()`: `file.split('\n')`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 249 in rash_core/src/docopt/options.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::str::Split<'_, char>` 

warning: useless conversion to the same type: `std::str::Split<'_, char>`
   --> rash_core/src/docopt/options.rs:248:13
    |
248 | /             doc.split('\n')
249 | |                 .into_iter()
    | |____________________________^ help: consider removing `.into_iter()`: `doc.split('\n')`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 209 in rash_core/src/modules/find.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `ignore::Walk` 

warning: useless conversion to the same type: `ignore::Walk`
   --> rash_core/src/modules/find.rs:191:31
    |
191 |       let result: Vec<String> = walk_builder
    |  _______________________________^
192 | |         // safe unwrap: default value defined
193 | |         .max_depth(match params.recurse.unwrap() {
194 | |             false => Some(1),
...   |
208 | |         .build()
209 | |         .into_iter()
    | |____________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing `.into_iter()`
    |
191 ~     let result: Vec<String> = walk_builder
192 +         // safe unwrap: default value defined
193 +         .max_depth(match params.recurse.unwrap() {
194 +             false => Some(1),
195 +             true => None,
196 +         })
197 +         // safe unwrap: default value defined
198 +         .follow_links(params.follow.unwrap())
199 +         // this prevents about unbounded feedback loops
200 +         .skip_stdout(true)
201 +         // safe unwrap: default value defined
202 +         // hidden criterion is opposite for params than for ignore library
203 +         .hidden(!params.hidden.unwrap())
204 +         .ignore(!params.hidden.unwrap())
205 +         .git_global(!params.hidden.unwrap())
206 +         .git_ignore(!params.hidden.unwrap())
207 +         .git_exclude(!params.hidden.unwrap())
208 +         .build()
    |

Check warning on line 69 in rash_core/src/modules/find.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived 

warning: this `impl` can be derived
  --> rash_core/src/modules/find.rs:65:1
   |
65 | / impl Default for FileType {
66 | |     fn default() -> Self {
67 | |         FileType::File
68 | |     }
69 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it...
   |
58 + #[derive(Default)]
59 | enum FileType {
   |
help: ...and mark the default variant
   |
61 ~     #[default]
62 ~     File,
   |

Check warning on line 192 in rash_core/src/docopt/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::str::Split<'_, char>` 

warning: useless conversion to the same type: `std::str::Split<'_, char>`
   --> rash_core/src/docopt/mod.rs:191:5
    |
191 | /     file.split('\n')
192 | |         .into_iter()
    | |____________________^ help: consider removing `.into_iter()`: `file.split('\n')`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 249 in rash_core/src/docopt/options.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::str::Split<'_, char>` 

warning: useless conversion to the same type: `std::str::Split<'_, char>`
   --> rash_core/src/docopt/options.rs:248:13
    |
248 | /             doc.split('\n')
249 | |                 .into_iter()
    | |____________________________^ help: consider removing `.into_iter()`: `doc.split('\n')`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default
View more details on GitHub Actions