fix/input empty string (#51)

* fix * add test
rask24 · Mar 27, 2024 · cd75ff2 · cd75ff2
1 parent 412c874
commit cd75ff2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/initialization/check_args.c b/src/initialization/check_args.c
@@ -6,7 +6,7 @@
 /*   By: reasuke <[email protected]>       +#+  +:+       +#+        */
 /*                                                +#+#+#+#+#+   +#+           */
 /*   Created: 2024/01/11 14:44:55 by reasuke           #+#    #+#             */
-/*   Updated: 2024/02/20 14:19:12 by reasuke          ###   ########.fr       */
+/*   Updated: 2024/03/27 13:07:53 by reasuke          ###   ########.fr       */
 /*                                                                            */
 /* ************************************************************************** */
 
@@ -20,8 +20,9 @@ static bool	_has_not_digit(int argc, char **argv)
 	i = 1;
 	while (i < argc)
 	{
+		errno = 0;
 		ft_strtol(argv[i], &end_ptr, 10);
-		if (*end_ptr)
+		if (*end_ptr || errno)
 			return (true);
 		i++;
 	}

diff --git a/test/unit/test_check_args.cpp b/test/unit/test_check_args.cpp
@@ -39,6 +39,14 @@ TEST(check_args, OneArgumentNonDigit) {
   EXPECT_EXIT(check_args(argc, argv), ::testing::ExitedWithCode(1), "Error\n");
 }
 
+TEST(check_args, OneArgumentEmptyString) {
+  int argc = 2;
+  const char *args[] = {"push_swap", ""};
+  char **argv = const_cast<char **>(args);
+
+  EXPECT_EXIT(check_args(argc, argv), ::testing::ExitedWithCode(1), "Error\n");
+}
+
 TEST(check_args, OneArgumentIncludingNonDigit) {
   int argc = 2;
   const char *args[] = {"push_swap", "42abc"};