Convert rgbx #48
Merged
Convert rgbx #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By analogy with our existing "RGB888", define "RGBX8888" to be RGBX in byte address order, i.e. V4L2-style rather than DRM-style. This implies that the ORDER_SWAPPED flag should not be set. These strings are private to libpisp and mostly used only by convert. Signed-off-by: Nick Hollinghurst <[email protected]>
We also check if the hardware platform supports this. Signed-off-by: Nick Hollinghurst <[email protected]>
This is largely a hack to support scaling by a factor of exactly 2; but nothing bad seems to happen when it is allowed (given we have a 2-pix-per-cycle ISP it's no more objectionable than odd-width 444). Signed-off-by: Nick Hollinghurst <[email protected]>
|
@naushir Not sure if this is worth merging -- it may conflict with work you are doing... |
naushir
approved these changes
Aug 1, 2025
By doubling the width, changing the output format to "UYVY" and applying a matrix to swap the first two colour components, we can output RGBX. The gotcha is that when downscaling, this can result in an oversharp/aliasy image. No support for RGBX input (though that would theoretically be possible at unity scale, using a customized Resample kernel). Signed-off-by: Nick Hollinghurst <[email protected]>
njhollinghurst
force-pushed
the
convert-rgbx
branch
from
c8664b3 to
8aa77a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to add RGBX support to the convert utility, including the workaround for RGBX output, even when Backend minor version is 0 (i.e. on BCM2712C1).
For clarity I have split this into 4 commits.
convertrespectively.