Sim #49
Merged
Sim #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were missing as we didn't previously specify the X value in RGBX formats. Signed-off-by: Naushir Patuck <[email protected]>
Some of the parameters in the FrontEnd object did not have getters, add them where missing. Signed-off-by: Naushir Patuck <[email protected]>
Some of the parameters in the BackEnd object did not have getters, add them where missing. While at it, add setters for max tile width and stripe height. Signed-off-by: Naushir Patuck <[email protected]>
Add AcquireBuffers() and ReleaseBuffers() to replace GetBuffers() and ReleaseBuffer(). Buffer handling is now moved to the caller, and buffers are passed into BackendDevice::Run() now. Signed-off-by: Naushir Patuck <[email protected]>
Rename BAYER to BAYER16 as this is strictly a 16-bit format. Remove shift from the format assignment, its value does not change the actual format. Signed-off-by: Naushir Patuck <[email protected]>
- Add a buffer_count parameter to Setup(), which can be used by the application to choose the number of buffers allocated. - Pass a pisp_image_format_config structure inot V4l2Device::SetFormat(). This is easer than passing the fields individually. Signed-off-by: Naushir Patuck <[email protected]>
In some situations, there is no direct mapping of a pisp image format to a V4L2 pixelformat. In such cases, use a generic/opaque buffer format (which happens to be a YUV444 multiplanar format), appropriately sized to fit the image contents. Signed-off-by: Naushir Patuck <[email protected]>
Allow the application to access the device node class through the BackendDevice object. Signed-off-by: Naushir Patuck <[email protected]>
These should be exposed for full functionality. Signed-off-by: Naushir Patuck <[email protected]>
This will run a handful of tests on the convert utility in the GitHub worker on a pull request. Signed-off-by: Naushir Patuck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.