Skip to content

Conversation

will-v-pi
Copy link
Contributor

Add a description of the picotool reboot command to the readme

@will-v-pi will-v-pi requested a review from lurch September 15, 2025 16:30
@lurch
Copy link
Contributor

lurch commented Sep 15, 2025

Probably also makes sense to update the "checking script" so that this (or other similar commands) can't get overlooked in future? 🤔

@will-v-pi
Copy link
Contributor Author

Probably also makes sense to update the "checking script" so that this (or other similar commands) can't get overlooked in future? 🤔

The reboot command would need it's own more complex handling added to the script, as the current script checks for the array of all the commands, but the reboot command is created outside of that array

Given it's unlikely there'll be another command like reboot which needs this handling, as I've moved to using load_guts, info_guts etc instead of calling reboot_cmd->execute, I think it's fine to not add handling to the script - now the command is in the README, it'll still be updated if the help text changes anyway

@lurch
Copy link
Contributor

lurch commented Sep 16, 2025

now the command is in the README, it'll still be updated if the help text changes anyway

Fair enough 👍

Comment on lines +581 to +582
-g <partition>
Select diagnostic partition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilograham Could we get a brief explanation of what the diagnostic partition is please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants