-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace big_text with hardcoded logo #1203
base: main
Are you sure you want to change the base?
Conversation
big_text.rs was a copy of the code from tui-big-text and was getting gradually out of sync with the original crate. It was also rendering something a bit different than the Ratatui logo. This commit replaces the big_text.rs file with a much smaller string representation of the Ratatui logo.
Q: Why not use |
tui-big-text depends on ratatui from crates.io. Afaik, it's not possible to compile a version that works with the version compiled from source when compiling examples as the widget traits don't match even though they are the same. P.s. This is not quite ready to merge. The GIF file size needs to under 10MB to make it possible for it to show in the readme. Intuitive things that would seem to make things smaller often don't (e.g. reducing the total time increases the file size), so it's a fun optimization problem of getting the timing of the destroy function timing and vhs script timing right. |
I think number of pixels that change in a gif affects the size. Maybe decrease the randomness a tad? Alternatively, you can record a |
Yep, this is one of the parameters I've been tweaking and which also has non-linear behavior
I don't like MOVs in this context as they tend to break (with a can't render error) on github often for some reason. That said, this might be a valid fall back position. I'd suggest running VHS locally Note the other thing I noticed is that there's a bit of extra space on the top and bottom of the frame. Not sure exactly what caused that however. Could be anything from OS update, font installation, ttyd change, vhs change, ? |
big_text.rs was a copy of the code from tui-big-text and was getting
gradually out of sync with the original crate. It was also rendering
something a bit different than the Ratatui logo. This commit replaces
the big_text.rs file with a much smaller string representation of the
Ratatui logo.