Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation preview #16

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Add documentation preview #16

merged 1 commit into from
Aug 22, 2023

Conversation

kdheepak
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-08-22 16:29 UTC

@kdheepak
Copy link
Contributor Author

kdheepak commented Aug 22, 2023

I had to make changes to the github workflow for previews to work, i.e. changing from deploying using a Github Action to using the classic gh-pages branch. This currently has broken the default documentation link for the ratatui-book.

image

I'm going to merge this without review. But feel free to still leave comments on this PR. I'll address them in subsequent PRs.

@kdheepak kdheepak merged commit 2ae01e8 into main Aug 22, 2023
2 checks passed
@kdheepak kdheepak deleted the fix-documentation branch August 22, 2023 16:29
@joshka
Copy link
Member

joshka commented Aug 22, 2023

For this, do you end up with a git repo having a million commits? I couldn't quite get the sense of how that action worked from a quick read of the overview.

@kdheepak
Copy link
Contributor Author

There will be a new commit that adds the preview content in a separate folder:

image

It also removes the content after PR is merged.

We can nuke the gh-pages at any point (while PRs are not open) and we will be fine, so I think this is a good system.

@kdheepak
Copy link
Contributor Author

At the moment, the action doesn't remove .nojekyll files. There's an issue to track this:

rossjrw/pr-preview-action#15

We can remove it ourselves manually or as part of the closed event on the action.

@joshka
Copy link
Member

joshka commented Aug 22, 2023

Ah. That was what I missed - the tool users try gh pages branch to track this.

@kdheepak
Copy link
Contributor Author

Yes. That’s why it is important to use the keep_files: true when deploying the build on the main branch to gh-pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants