Preserve loaded filament palette when importing colored 3MF files#60
Open
gigq wants to merge 2 commits intoratdoux:mainfrom
Open
Preserve loaded filament palette when importing colored 3MF files#60gigq wants to merge 2 commits intoratdoux:mainfrom
gigq wants to merge 2 commits intoratdoux:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
This changes colored 3MF import so the app keeps the user's currently loaded physical filaments instead of replacing them with the colors embedded in the 3MF project.
When a colored 3MF is imported, the importer now:
This also fixes a UI refresh issue where physical filament swatches could stay stale after import when the filament count did not change, and refreshes mixed filament display colors for manual-pattern entries.
Why
Before this change, importing a colored 3MF could overwrite the visible filament colors in slots 1-4 with the file's palette, even when the user wanted to keep a fixed physical palette loaded and approximate the model colors from that palette.
That caused the sidebar swatches, multicolor preview, and actual print intent to drift apart.
What changed
Notes
This is a heuristic color approximation based on the currently loaded palette. It improves import behavior for fixed-palette workflows, but it is not a full physical pigment/translucency model and does not guarantee exact printed color matching.