Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved card0 check to config & Flux lib #194

Closed
wants to merge 1 commit into from

Conversation

cydh
Copy link
Contributor

@cydh cydh commented Jun 20, 2018

  • Fixed Outdated card0 checks #190
  • The card0 values are defined in config file (application.php) in ItemSpecial. By default, using rAthena's card0 values.
  • The usage will be Flux::itemIsSpecial($item). Returns true if item's card0 is special, false otherwise
  • For control checking if item is forged, brew/getnameditem, or pet egg
    • if ($item->card0 == $this->itemIsForged)
    • if ($item->card0 == $this->itemIsCreation)
    • if ($item->card0 == $this->itemIsPetEgg)

* Fixed rathena#190
* The card0 values are defined in config file (application.php) in `ItemSpecial`. By default, using rAthena's card0 values.
* The usage will be `Flux::itemIsSpecial($item)`. Returns `true` if item's card0 is special, `false` otherwise
* For control checking (ifs) for item is forged
  * `if ($item->card0 == $this->itemIsForged)`
  * `if ($item->card0 == $this->itemIsCreation)`
  * `if ($item->card0 == $this->itemIsPetEgg)`
@cydh cydh mentioned this pull request Jun 20, 2018
@cydh cydh mentioned this pull request Jul 10, 2018
@cydh
Copy link
Contributor Author

cydh commented Apr 1, 2019

See #201

@cydh cydh closed this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant