Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured FluxCP to be PSR-4 compliance #232

Closed
wants to merge 6 commits into from

Conversation

secretdataz
Copy link
Member

  • Now using Composer to handle dependencies. Supersedes Composer-ing components #210.
  • Now using PSR-4 autoloader to handle class loading. No more requires_once hell.
  • Also used filp/whoops to handle errors and exceptions instead of Flux's own handler.
  • FluxCP no longer expose unnecessary information in production environment unless configured to.
  • Moved some environment-specific settings into .env file. Provides more flexible developer experience.
  • Breaks every single existing themes and addons. Updates required are minor since modules and themes haven't been restructured.

@sanasol
Copy link
Member

sanasol commented Mar 29, 2019

That's awesome no doubt.
But killing all themes/addons and backward compatibility is looks really bad.

Maybe we should try to do softer upgrade first and keep compatibility at least for some fixed time.
So addon/theme makers will have time to upgrade their code.

Also need prepare step-by-step upgrade guide.
I believe that laravel-style will perfectly fit for it - https://laravel.com/docs/5.8/upgrade

@secretdataz
Copy link
Member Author

According to Cydh and Akkarin's suggestion, they are okay with setting a life time for current FluxCP version and draft a major release. While we wait for the end-of-life, we can add more things to the soon-to-be major release.

@secretdataz
Copy link
Member Author

Superseded by #233

@secretdataz secretdataz deleted the modernize branch March 30, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants