Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Document-extensions pages batch - Time series [Replace C# samples] #1879

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

reebhub
Copy link
Contributor

@reebhub reebhub commented Jul 22, 2024

Related issues:
RDoc-2894 Time series > Client API > Session > Append
RDoc-2895 Time series > Client API > Session > Delete
RDoc-2897 Time series > Client API > Session > Get > Get entries
RDoc-2898 Time series > Client API > Session > Get > Get names
RDoc-2899 Time series > Querying > Overview & syntax
RDoc-2896 Time series > Client API > Session > Patch
RDoc-2900 Time series > Querying > Choosing query range
RDoc-2904 Time series > Rollups and retentions
RDoc-2903 Time series > Indexing timeseries
RDoc-2901 Time series > Querying > Filtering
RDoc-2902 Time series > Querying > Using indexes


{NOTE: }

* Use `time_series_for.append` for the following actions:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Use `time_series_for.append` for the following actions:
* Use `time_series_for.append_single` for the following actions:

Copy link
Contributor Author

@reebhub reebhub Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (now referencing both append_single and append)

Appending a new entry to an existing time series
will add the entry to the series at the specified timestamp.
* **Modifying an existing time series entry**
Use `append` to update the data of an existing entry with the specified timestamp.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Python, append_single appends single-value entry, append can append list of entries at the same timestamp (as a single entry).

Suggested change
Use `append` to update the data of an existing entry with the specified timestamp.
Use `append_single` to update the data of an existing entry with the specified timestamp.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

append may be correct here too, but just to let you know that we have two methods for it in Python, depending what type of value single entry represents - single value or multiple values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, now referencing both methods


* [document_query](../../../client-api/session/querying/how-to-query#query-overview)

{CODE-BLOCK: JSON}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in Python, a document query is more like a piece of trivia as the simple query works the same way and many variants of this method help with querying (query_index_type, query_collection, etc.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should care where we want to include it in the docs
as it may be misleading
query methods are more comfortable to use than document_query

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the document_query link so it would reference the query-vs-document_query page, where your basic explanation of this point appears


| Property | Type | Description |
|-----------------|------|-------------|
| **collections** | `Dict` | Populate this `Dictionary` with the collection names and their corresponding `TimeSeriesCollectionConfiguration` objects. |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| **collections** | `Dict` | Populate this `Dictionary` with the collection names and their corresponding `TimeSeriesCollectionConfiguration` objects. |
| **collections** | `Dict[str, TimeSeriesCollectionConfiguration]` | Populate this `Dictionary` with the collection names and their corresponding `TimeSeriesCollectionConfiguration` objects. |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ppekrol ppekrol merged commit e0d55b8 into ravendb:master Aug 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants